chore: Bump selected-network-controller to v21 #13109
Open
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version is functionally equivalent to v19. v20 enabled the Per-Dapp Selected Network feature by default and removed the option to disable it. This would have broken Mobile since that feature has not been integrated here yet. That has been reverted to v21, so this commit essentially ensures that Mobile is using the latest version of `selected-network-controller`.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mcmire
changed the title
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
added
the
No QA Needed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version is functionally equivalent to v19. v20 enabled the Per-Dapp Selected Network feature by default and removed the option to disable it. This would have broken Mobile since that feature has not been integrated here yet. That has been reverted to v21, so this commit essentially ensures that we are using the latest version of
selected-network-controllerfor parity with Extension.Related issues
Fixes #13104.
Manual testing steps
No manual testing steps needed since the Per-Dapp Selected Network feature is still behind a feature flag.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist