chore: Token list performance measurement #13084

tommasini · 2025-01-20T22:57:12Z

Description

Add measurement to token list , and also bring back the mobile vitals from Sentry automatic instrumentation and fix an issue in navigation initialisation

Android:
https://metamask.sentry.io/performance/trace/ddeeac4cfa504564ab600ef97183d043/?node=trace-root&pageEnd&pageStart&project=2651591&source=traces&statsPeriod=10m&timestamp=1737413566.202
(some issues around building android, this is something I tested before but now with some difficulties building android because I'm working at rn upgrade )

IOS:
https://metamask.sentry.io/performance/trace/1967ef653997469ca30a6d4297fa7d31/?node=txn-628f90c22c2c491a910662167979c0c3&pageEnd&pageStart&project=2651591&source=traces&statsPeriod=10m&timestamp=1737543334.368

Token list function is being called multiple times, this will change at this PR: #12843

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… mobile vitals from Sentry automatic instrumentation

github-actions · 2025-01-20T22:57:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-01-20T22:57:42Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 93874fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/40bb9f48-a083-4138-a86f-3f5f207ebc34

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2025-01-20T23:07:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (faf5340) to head (93874fe).
Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13084      +/-   ##
==========================================
+ Coverage   59.83%   60.00%   +0.16%     
==========================================
  Files        1873     1891      +18     
  Lines       42121    42467     +346     
  Branches     5473     5601     +128     
==========================================
+ Hits        25204    25482     +278     
- Misses      15235    15256      +21     
- Partials     1682     1729      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ion trace bug fix

app/components/UI/Tokens/index.tsx

github-actions · 2025-01-22T11:06:25Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8a97b8a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f958b589-0207-4b00-99b6-e8b386436b07

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-01-22T11:15:01Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0e2b2f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37c2941f-8945-467a-bbf1-7e8fda0ad698

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-01-22T12:36:00Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 724570b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18640592-02d1-4b83-89cf-a8b234335361

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

MarioAslau

Looks great Tomas <3

github-actions · 2025-01-22T17:32:55Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0e73119
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/368e071e-fd6f-4108-ac40-a4de197013cf

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-01-22T17:43:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Add measurement do wallet mounting component, and also bring back the…

93874fe

… mobile vitals from Sentry automatic instrumentation

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 20, 2025

tommasini requested a review from a team as a code owner January 20, 2025 22:57

add ref for only call trace at the first render

1294075

gauthierpetetin assigned tommasini Jan 21, 2025

tommasini changed the title ~~chore: Wallet performance measurement~~ chore: Token list performance measurement Jan 21, 2025

remove wallet measurement and add token list measurement; Add navigat…

295f1d3

…ion trace bug fix

tommasini requested a review from a team as a code owner January 21, 2025 23:18

salimtb reviewed Jan 22, 2025

View reviewed changes

app/components/UI/Tokens/index.tsx Outdated Show resolved Hide resolved

salimtb reviewed Jan 22, 2025

View reviewed changes

app/components/UI/Tokens/index.tsx Show resolved Hide resolved

Merge branch 'main' into chore/wallet-performance-sentry

fefea48

tommasini removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025

add tags to the token list and fix import lint issue

8a97b8a

tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025

salimtb previously approved these changes Jan 22, 2025

View reviewed changes

fix lint issues removing no needed imports at wallet view

0e2b2f7

tommasini dismissed salimtb’s stale review via 0e2b2f7 January 22, 2025 11:13

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025

salimtb approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' into chore/wallet-performance-sentry

724570b

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025

MarioAslau approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' into chore/wallet-performance-sentry

0e73119

MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Token list performance measurement #13084

chore: Token list performance measurement #13084

tommasini commented Jan 20, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025 •

edited by metamaskbot

Loading

codecov-commenter commented Jan 20, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading

MarioAslau left a comment

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Jan 22, 2025

chore: Token list performance measurement #13084

Are you sure you want to change the base?

chore: Token list performance measurement #13084

Conversation

tommasini commented Jan 20, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 20, 2025

github-actions bot commented Jan 20, 2025 • edited by metamaskbot Loading

Bitrise

codecov-commenter commented Jan 20, 2025

Codecov Report

github-actions bot commented Jan 22, 2025

Bitrise

github-actions bot commented Jan 22, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jan 22, 2025 • edited by metamaskbot Loading

Bitrise

MarioAslau left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 22, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Jan 22, 2025

Quality Gate passed

tommasini commented Jan 20, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 22, 2025 •

edited by metamaskbot

Loading