Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix holesky network balance included in aggregated balance on ma… #13057

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: fix holesky network balance included in aggregated balance on ma… #13057

wants to merge 5 commits into from
+11 −7

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 17, 2025 •
edited
Loading

Description

ETH balance on Holesky (testnet) is included in the total balance when selecting ‘Popular networks’

Related issues

Fixes:

Manual testing steps

  1. Acquire some balance on Holesky
  2. Add Holesky network using chainlist.
  3. Click on popular networks. Aggregated balance you see should not include the holesky balance you own.

Screenshots/Recordings

Before

image
image
image

After

Screen.Recording.2025-01-17.at.15.40.43.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c2b93d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1c84ed2-6b9d-479f-a7e5-31f004198504

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review January 17, 2025 15:41
@sahar-fehri sahar-fehri requested a review from a team as a code owner January 17, 2025 15:41
nickewansmith
nickewansmith previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

salimtb
salimtb previously approved these changes Jan 17, 2025
View reviewed changes
tommasini
tommasini previously approved these changes Jan 22, 2025
View reviewed changes
app/selectors/tokensController.ts Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri dismissed stale reviews from nickewansmith, salimtb, and tommasini via d6e9cc9 January 22, 2025 15:29
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d6e9cc9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54bdfb05-3648-4198-a99d-43aa76c153ba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1979d4e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64084f56-bf87-4dc8-891e-e37be921f42d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommasini tommasini tommasini left review comments

@salimtb salimtb salimtb left review comments

@nickewansmith nickewansmith nickewansmith left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Status: Review finalised - Ready to be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sahar-fehri @nickewansmith @salimtb @tommasini @metamaskbot