Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix insufficient funds displays incorrect native token #29828

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jan 21, 2025

Description

This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token #28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH".

Open in GitHub Codespaces

Related issues

#28867

Manual testing steps

  1. Select Polygon
  2. Trigger a dapp tx with an account without funds (you can use these tests https://metamask.github.io/test-dapp/)
  3. Click on the Alert
  4. See POL as the token name

Screenshots/Recordings

Before

After

https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [969744b]
Page Load Metrics (1681 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14552122168115273
domContentLoaded14482109166815172
load14562122168115273
domInteractive24139492512
backgroundConnect65215136
firstReactRender1575432512
getState410621
initialActions0452105
loadScripts10481653123113465
setupStore66112168
uiStartup16652415193118287
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -1.65 KiB (-0.03%)
  • ui: 189 Bytes (0.00%)
  • common: -2 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [537f5ed]
Page Load Metrics (1825 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint149325271828283136
domContentLoaded148525031803281135
load149425731825287138
domInteractive26169663919
backgroundConnect66622178
firstReactRender1692442813
getState57215188
initialActions01000
loadScripts108320051365248119
setupStore662192110
uiStartup180229012133288138
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 192 Bytes (0.00%)
  • common: -2 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [776040a]
Page Load Metrics (1956 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17072268196016077
domContentLoaded16622254192916378
load17022265195616077
domInteractive278142178
backgroundConnect116524178
firstReactRender17100352512
getState783292412
initialActions01000
loadScripts12081730144015072
setupStore764232211
uiStartup196628862264223107
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 192 Bytes (0.00%)
  • common: -2 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [bb5ff52]
Page Load Metrics (1747 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15722116175512661
domContentLoaded15562103172312359
load15692119174712962
domInteractive2594432110
backgroundConnect97624199
firstReactRender16100412914
getState47317209
initialActions01000
loadScripts10811553125510550
setupStore87417209
uiStartup17642499202520397
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 192 Bytes (0.00%)
  • common: -2 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants