-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 fix insufficient funds displays incorrect native token #29828
Draft
matteoscurati
wants to merge
4
commits into
main
Choose a base branch
from
fix/fix-insufficient-funds-displays-incorrect-native-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: 🐛 fix insufficient funds displays incorrect native token #29828
matteoscurati
wants to merge
4
commits into
main
from
fix/fix-insufficient-funds-displays-incorrect-native-token
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matteoscurati
added
team-assets
and removed
team-notifications
Notifications team
labels
Jan 21, 2025
Builds ready [969744b]
Page Load Metrics (1681 ± 73 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [537f5ed]
Page Load Metrics (1825 ± 138 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [776040a]
Page Load Metrics (1956 ± 77 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [bb5ff52]
Page Load Metrics (1747 ± 62 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token #28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH".
Related issues
#28867
Manual testing steps
Screenshots/Recordings
Before
After
https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8
Pre-merge author checklist
Pre-merge reviewer checklist