Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change alert modal copy #29475

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: change alert modal copy #29475

wants to merge 4 commits into from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jan 7, 2025

Description

This PR aims to update the copy of the alert modal (title and description).

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3731

Manual testing steps

You need to trigger a Danger alert (resimulation, domain mismatch or signing or Submitting)

  1. Go to this the Test Dapp
  2. Trigger a request
  3. Acknowledge the Danger alert

Screenshots/Recordings

image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review January 7, 2025 14:48
@metamaskbot
Copy link
Collaborator

Builds ready [1d07c23]
Page Load Metrics (1610 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14841883161210048
domContentLoaded1433183415849646
load14841880161010148
domInteractive226938178
backgroundConnect97130199
firstReactRender1691292311
getState55914157
initialActions00000
loadScripts1055139111728441
setupStore65112126
uiStartup16462120183213163

matthewwalsh0
matthewwalsh0 previously approved these changes Jan 7, 2025
jpuri
jpuri previously approved these changes Jan 8, 2025
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vinistevam vinistevam dismissed stale reviews from jpuri and matthewwalsh0 via 5e5a36b January 8, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants