fix: Misdefined types related to Bridge{,Status}Controller state

[MajorLift]

Description

• The first commit (65d78c9) fixes errors in the messenger types for Bridge{,Status}Controller.
• The second commit (b8765f9) is optional, but strongly recommended. Under the BaseController API with which the Bridge{,Status}Controller are defined, BridgeControllerState and BridgeStatusControllerState should be considered to be reserved keywords.
  • The current set of types violates guidelines: https://github.com/MetaMask/core/blob/main/docs/writing-controllers.md#define-and-export-a-type-for-the-controllers-state.
  • Deviating from this convention breeds confusion and silently-failing errors as per the examples fixed in the first commit.
  • This also affects downstream consumers and dependent modules of the bridge controllers, as the expected functionality for the reserved keywords is not fulfilled.
  • The type expressions { bridgeState: BridgeControllerState }, { bridgeStatusState: BridgeStatusControllerState } are being used redundantly and should be de-duplicated. However, defining these types using anything other than the reserved keywords will cause further unnecessary confusion.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b8765f9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1700 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1463	1915	1698	98	47
		domContentLoaded	1412	1903	1670	105	50
		load	1454	1917	1700	103	49
		domInteractive	25	230	73	63	30
		backgroundConnect	9	61	25	15	7
		firstReactRender	16	83	36	24	11
		getState	5	59	23	21	10
		initialActions	0	1	0	0	0
		loadScripts	1044	1454	1254	86	41
		setupStore	6	55	10	10	5
		uiStartup	1691	2106	1917	119	57