test: Swap tests addition #29442

davibroc · 2025-01-06T17:38:44Z

Description

Adding Linea Tests as well as test for getting a quote on Mainnet.

To run the tests locally use yarn playwright test --project=swap

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-06T17:38:58Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-06T21:53:06Z

Builds ready [138305d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1668 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1470	1893	1671	110	53
		domContentLoaded	1426	1821	1639	106	51
		load	1473	1845	1668	104	50
		domInteractive	26	39	31	4	2
		backgroundConnect	8	67	33	20	9
		firstReactRender	16	79	38	25	12
		getState	5	55	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	1010	1384	1203	99	48
		setupStore	7	52	12	13	6
		uiStartup	1700	2102	1905	110	53

metamaskbot · 2025-01-06T21:53:19Z

Builds ready [138305d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1603 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1454	2338	1610	182	87
		domContentLoaded	1405	2311	1581	183	88
		load	1450	2321	1603	180	86
		domInteractive	22	161	37	30	14
		backgroundConnect	7	75	20	19	9
		firstReactRender	15	95	43	27	13
		getState	5	48	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	998	1875	1162	177	85
		setupStore	6	9	7	1	0
		uiStartup	1637	2558	1829	216	104

metamaskbot · 2025-01-06T21:58:31Z

Builds ready [138305d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1794 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1563	2201	1800	217	104
		domContentLoaded	1553	2153	1767	214	103
		load	1563	2205	1794	215	103
		domInteractive	25	82	41	16	8
		backgroundConnect	10	72	28	20	10
		firstReactRender	16	99	49	29	14
		getState	5	77	16	20	10
		initialActions	0	1	0	0	0
		loadScripts	1140	1616	1325	170	82
		setupStore	6	78	18	21	10
		uiStartup	1743	2894	2078	303	146

metamaskbot · 2025-01-07T10:17:02Z

Builds ready [44fb201]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1893 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	293	2290	1820	391	188
		domContentLoaded	1586	2273	1866	172	83
		load	1602	2287	1893	170	82
		domInteractive	29	103	46	21	10
		backgroundConnect	9	73	32	23	11
		firstReactRender	18	101	53	30	15
		getState	6	66	22	19	9
		initialActions	0	1	0	0	0
		loadScripts	1096	1763	1381	152	73
		setupStore	7	91	26	27	13
		uiStartup	1878	3179	2283	330	158

metamaskbot · 2025-01-07T11:07:37Z

Builds ready [44fb201]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1702 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1507	2099	1707	161	77
		domContentLoaded	1425	2085	1671	170	81
		load	1438	2103	1702	168	81
		domInteractive	25	198	56	42	20
		backgroundConnect	9	93	30	24	11
		firstReactRender	15	75	32	21	10
		getState	5	65	18	18	9
		initialActions	0	0	0	0	0
		loadScripts	1047	1589	1251	131	63
		setupStore	6	84	24	25	12
		uiStartup	1669	2317	1964	206	99

metamaskbot · 2025-01-07T11:08:40Z

Builds ready [44fb201]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1771 ± 164 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1453	3081	1769	340	163
		domContentLoaded	1426	3071	1745	343	165
		load	1454	3082	1771	341	164
		domInteractive	21	177	44	36	17
		backgroundConnect	8	74	26	19	9
		firstReactRender	15	71	31	21	10
		getState	5	52	15	15	7
		initialActions	0	0	0	0	0
		loadScripts	1010	2221	1285	264	127
		setupStore	6	83	19	23	11
		uiStartup	1620	3509	2007	385	185

metamaskbot · 2025-01-07T11:08:42Z

Builds ready [44fb201]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1525 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1386	1711	1532	86	41
		domContentLoaded	1379	1681	1505	79	38
		load	1388	1715	1525	86	41
		domInteractive	24	125	36	25	12
		backgroundConnect	8	54	22	15	7
		firstReactRender	16	98	31	25	12
		getState	4	56	22	20	10
		initialActions	0	1	0	0	0
		loadScripts	983	1271	1118	75	36
		setupStore	6	74	13	17	8
		uiStartup	1590	2138	1774	130	63

metamaskbot · 2025-01-07T14:26:32Z

Builds ready [c1230c5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1681 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1518	1945	1684	117	56
		domContentLoaded	1469	1927	1652	115	55
		load	1526	1950	1681	112	54
		domInteractive	24	83	39	15	7
		backgroundConnect	8	60	29	19	9
		firstReactRender	16	97	50	29	14
		getState	5	56	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	1037	1461	1217	109	52
		setupStore	6	55	13	14	7
		uiStartup	1709	2580	1964	223	107

test/e2e/playwright/swap/specs/swap.spec.ts

Added Mainnet tests

138305d

metamaskbot added the team-swaps label Jan 6, 2025

davibroc changed the title ~~Added Mainnet tests~~ test: Swap tests fixes Jan 6, 2025

Added Linea tests

44fb201

Small fix

c1230c5

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 7, 2025

davibroc changed the title ~~test: Swap tests fixes~~ test: Swap tests addition Jan 7, 2025

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 7, 2025

chloeYue reviewed Jan 7, 2025

View reviewed changes

test/e2e/playwright/swap/specs/swap.spec.ts Show resolved Hide resolved

chloeYue approved these changes Jan 7, 2025

View reviewed changes

C-Ivan self-requested a review January 7, 2025 17:59

C-Ivan approved these changes Jan 7, 2025

View reviewed changes

davibroc added this pull request to the merge queue Jan 8, 2025

Merged via the queue into main with commit 40417b0 Jan 8, 2025
97 checks passed

davibroc deleted the fix/swaps-tests branch January 8, 2025 09:28

github-actions bot locked and limited conversation to collaborators Jan 8, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Swap tests addition #29442

test: Swap tests addition #29442

davibroc commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

test: Swap tests addition #29442

test: Swap tests addition #29442

Conversation

davibroc commented Jan 6, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 6, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

davibroc commented Jan 6, 2025 •

edited

Loading