Skip to content

Commit

Permalink
cherry-pick: Adding production URL for signature decoding (#28951)
Browse files Browse the repository at this point in the history
## **Description**

Production URL for signature decoding.
Original PR: #28918
Cherry-picked commit:
bf946bc

## **Related issues**

Fixes: #28892

## **Manual testing steps**
NA

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
jpuri authored Dec 5, 2024
1 parent 0d9bd9d commit 8cd3ced
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ env:
# Used to enable confirmation redesigned pages
- ENABLE_CONFIRMATION_REDESIGN: ''
# URL of the decoding API used to provide additional data from signature requests
- DECODING_API_URL: 'https://qtgdj2huxh.execute-api.us-east-2.amazonaws.com/uat/v1'
- DECODING_API_URL: 'https://signature-insights.api.cx.metamask.io/v1'
# Determines if feature flagged Settings Page - Developer Options should be used
- ENABLE_SETTINGS_PAGE_DEV_OPTIONS: false
# Used for debugging changes to the phishing warning page.
Expand Down
2 changes: 1 addition & 1 deletion privacy-snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"price.api.cx.metamask.io",
"proxy.api.cx.metamask.io",
"proxy.dev-api.cx.metamask.io",
"qtgdj2huxh.execute-api.us-east-2.amazonaws.com",
"signature-insights.api.cx.metamask.io",
"raw.githubusercontent.com",
"registry.npmjs.org",
"responsive-rpc.test",
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/confirmations/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Driver } from '../../webdriver/driver';
import Confirmation from '../../page-objects/pages/confirmations/redesign/confirmation';

export const DECODING_E2E_API_URL =
'https://qtgdj2huxh.execute-api.us-east-2.amazonaws.com/uat/v1';
'https://signature-insights.api.cx.metamask.io/v1';

export async function scrollAndConfirmAndAssertConfirm(driver: Driver) {
const confirmation = new Confirmation(driver);
Expand Down

0 comments on commit 8cd3ced

Please sign in to comment.