docker fix #16
Merged
docker fix #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR. However, it seems that the building process still got issues: |
@Larvan2 Please check this PR. I tested on my own repo. It's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/MetaCubeX/subconverter/actions/runs/11338883825/job/31533180527
@Larvan2 It seems that the docker build Github Action is broken after the docker update. It's due to the multi architecture manifest problem. Check the step "Merge and push manifest on master branch" in the link.
https://github.com/tindy2013/subconverter/commits/master/.github/workflows/docker.yml
I'm try to follow the fix commit on Apr 3, 2024 from orignal repo and proprose a PR.
But I can't test it myself.
Could you please have a look? Thank you.