Requestion gsDesign2 >= v1.1.3 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh actually you might not be able to pass the automated check on CRAN because gsDesign2 1.1.3 is too new, which may not be available on CRAN's check machines yet, but you can certainly try. If it fails to pass today, you can retry the submission tomorrow and I guess it should be able to pass automatically. Feel free to ping me here if you encounter any problems during the submission. |
nanxstats
approved these changes
Nov 15, 2024
|
Thank you, @yihui, for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #297.
John might be off today. @nanxstats and @yihui, could you please review and approve it? I will prepare a CRAN submission after your approval.