Test get_analysis_date() #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| test_that("target_event_overall", { | ||
| observed <- get_analysis_date(simulated_data, target_event_overall = 300) | ||
| expect_equal(observed, 25.6150577826303) |
There was a problem hiding this comment.
Could you kindly explain the purpose of the testing done after line 49? The output 25.6150577826303 is an unvalidated result. I understand that you may have performed these tests to verify the data.table transformation. If that's the case, would it be possible to rename the file to something like "test-compare with original function output - get_analysis_date"?
There was a problem hiding this comment.
Yes, I need tests in order to refactor the code. This is the only way we will know it continues to behave as you originally designed it. How about test-unvalidated-get_analysis_date.R?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the examples to tests. From running covr locally,
get_analysis_date()now has 95.45% coverage