Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backwards compatibility tests for data.table conversion #135

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove backwards compatibility tests for data.table conversion #135

merged 1 commit into from
Nov 13, 2023

Conversation

jdblischak
Copy link
Collaborator

These tests have served their purpose. The existing functions have all been successfully converted to data.table

xref: #111 (comment)

@jdblischak jdblischak requested a review from nanxstats November 13, 2023 16:01
@jdblischak jdblischak self-assigned this Nov 13, 2023
nanxstats
nanxstats approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great milestone achieved! 🥳

@nanxstats nanxstats merged commit d5b6631 into Merck:main Nov 13, 2023
7 checks passed
@jdblischak jdblischak deleted the remove-backwards-compatibility-tests branch November 13, 2023 17:04
@nanxstats nanxstats mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees

@jdblischak jdblischak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdblischak @nanxstats