Devr 3502 valid func react base char subgroup #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'DEVR-3502_valid_func_react_base_char_subgroup' of https://github.com/Merck/metalite.sl into DEVR-3502_valid_func_react_base_char_subgroup # Conflicts: # tests/testthat/_snaps/independent-testing-react_subgroup_table/react_subgroup_table.html # tests/testthat/test-independent-testing-react_subgroup_table.R
Merge branch 'DEVR-3502_valid_func_react_base_char_subgroup' of https://github.com/Merck/metalite.sl into DEVR-3502_valid_func_react_base_char_subgroup # Conflicts: # tests/testthat/test-independent-testing-react_subgroup_table.R
wangben718
approved these changes
Jan 29, 2025
| test_that("Testing react_subgroup_table function via calling react_base_char function", { | ||
| library(reactable) | ||
| library(htmltools) | ||
| if (!require("htmlwidgets", character.only = TRUE)) { |
There was a problem hiding this comment.
Is there any other way to avoid using htmlwidgets? Otherwise, we need to add this dipendency into DESCRIPTION file.
There was a problem hiding this comment.
Could we remove this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test of react_subgroup_table() is done through calling the react_base_char().