Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running time of gs_design_wlr example is > 5s #491

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

LittleBeannie
Copy link
Collaborator

@LittleBeannie LittleBeannie commented Nov 14, 2024

To solve notes listing in #490.

@LittleBeannie LittleBeannie self-assigned this Nov 14, 2024
@LittleBeannie LittleBeannie linked an issue Nov 14, 2024 that may be closed by this pull request
@jdblischak
Copy link
Collaborator

So the NOTE is only for examples that take longer than 10 seconds? Do I understand correctly? Because we are still getting examples that take more than 5 seconds, eg from ubuntu-latest with R devel

* checking examples ... [28s/26s] OK
Examples with CPU (user + system) or elapsed time > 5s
               user system elapsed
gs_update_ahr 5.547  0.015   4.549
gs_design_wlr 5.220  0.008   4.529

Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming that CRAN accepts examples that take more than 5 seconds but less than 10

@LittleBeannie LittleBeannie merged commit cbc103e into main Nov 15, 2024
7 checks passed
@LittleBeannie LittleBeannie deleted the 490-2-notes-from-cran-pre-test-on-v113 branch November 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 Notes from CRAN pre-test on v1.1.3
2 participants