External blob storage service #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- docker-compose.yaml: use default network; create volumes - deploy_api.sh: rebuild all services and reinitialize volumes - pyproject.toml, pdm.lock: add minio dependency - app.py: raise exceptions in development mode, pass in s3 client - lib.py: extend helper functionality to persist blobs in s3 - create alembic revision for external blobs - move dockerfiles into services/* with start.sh scripts
- stream in chunks - attach whether late_bytes are inline as metadata in blob storage - don't use composite objects to persist late_bytes - don't allow users to submit late_bytes more than once per session
Closed
jayceslesar
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65. Currently broken:
late_bytesfails to synchronize with the database, causingtest_api.test_demo_streamingto break.If that gets fixed it's probably ready to merge.