-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows GUI: Add evergreen online/stub installer #991
base: master
Are you sure you want to change the base?
Conversation
970b05e
to
bcafc08
Compare
a1a3efd
to
a79e8d6
Compare
Note: the evergreen online/stub installer is not working as intended because https://mediaarea.net/mediainfo_check/version.txt is returning changelog.bin instead of version.txt. |
Update: the evergreen online/stub installer is now working as intended since the server is now serving the expected file. So the only thing is whether we want to add signature verification. If yes, need to add the third party NSIS plugin DLL to the repository containing NSIS first. |
I like the maximum balance between security, file size and dev time, if you consider that it is fine for you to add it I take it
Which NSIS plugin DLL? |
As I mentioned earlier here, there are two possible plugins that I know of that should work. As far as I know, NSIS does not have built-in signature verification features so third party plugin is needed. The plugins basically calls Windows built-in verification features. |
It helps about maintenance. |
I can try to compile that and add the verification to our script and see if it works first. |
ad62dcf
to
9ed7ea1
Compare
Done adding digital signature verification using the Mozilla CertCheck plugin. Both online installers are still under 100KiB. The source code for the plugin can be obtained from: The pre-built and digitally signed plugin DLL can be obtained from: |
Add a version-less evergreen online/stub installer that will install the latest available suitable version for all Windows versions and architectures.
Also update the versioned online/stub installer to be consistent with the version-less one and simplify it.