Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Add evergreen online/stub installer #991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Dec 9, 2024

Add a version-less evergreen online/stub installer that will install the latest available suitable version for all Windows versions and architectures.

Also update the versioned online/stub installer to be consistent with the version-less one and simplify it.

@cjee21 cjee21 force-pushed the NSIS branch 3 times, most recently from 970b05e to bcafc08 Compare December 9, 2024 14:26
@cjee21 cjee21 force-pushed the NSIS branch 2 times, most recently from a1a3efd to a79e8d6 Compare December 10, 2024 11:27
@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 10, 2024

Note: the evergreen online/stub installer is not working as intended because https://mediaarea.net/mediainfo_check/version.txt is returning changelog.bin instead of version.txt.

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 13, 2024

Update: the evergreen online/stub installer is now working as intended since the server is now serving the expected file.

So the only thing is whether we want to add signature verification. If yes, need to add the third party NSIS plugin DLL to the repository containing NSIS first.

@JeromeMartinez
Copy link
Member

So the only thing is whether we want to add signature verification.

I like the maximum balance between security, file size and dev time, if you consider that it is fine for you to add it I take it ☺️.

If yes, need to add the third party NSIS plugin DLL to the repository containing NSIS first.

Which NSIS plugin DLL?

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 13, 2024

Which NSIS plugin DLL?

As I mentioned earlier here, there are two possible plugins that I know of that should work. As far as I know, NSIS does not have built-in signature verification features so third party plugin is needed. The plugins basically calls Windows built-in verification features.

@JeromeMartinez
Copy link
Member

The plugins basically calls Windows built-in verification features.

It helps about maintenance.
I have a preference for the Mozilla one, easy to add to the source code and we built it.
Can you start without our repo having the binary?

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 13, 2024

The plugins basically calls Windows built-in verification features.

It helps about maintenance. I have a preference for the Mozilla one, easy to add to the source code and we built it. Can you start without our repo having the binary?

I can try to compile that and add the verification to our script and see if it works first.

@cjee21 cjee21 force-pushed the NSIS branch 2 times, most recently from ad62dcf to 9ed7ea1 Compare December 13, 2024 15:19
@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 14, 2024

Done adding digital signature verification using the Mozilla CertCheck plugin.

Both online installers are still under 100KiB.

The source code for the plugin can be obtained from:
https://github.com/mozilla/gecko-dev/tree/master/other-licenses/nsis/Contrib/CertCheck

The pre-built and digitally signed plugin DLL can be obtained from:
https://github.com/mozilla/gecko-dev/blob/master/other-licenses/nsis/Plugins/CertCheck.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants