Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Reset Text and Tree views colours to default #952

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Nov 13, 2024

The final change for Tree and Text view background colour. Use the default colour selected by VCL / Windows for these kind of views. Any dissatisfaction is no longer the responsibility of MediaInfo's codes.

@JeromeMartinez
Copy link
Member

Maybe checking the actual color and if > 249 we set 249? So it is not too much white when white is the default and we keep other default values.

@cjee21
Copy link
Collaborator Author

cjee21 commented Nov 13, 2024

Maybe checking the actual color and if > 249 we set 249? So it is not too much white when white is the default and we keep other default values.

So far I have been setting colours using the GUI form editor and do not know/want to write codes for that. I do not think 255 is an issue because it is used by almost all Windows apps by default including web browsers and File Explorer. Only some apps use 249 but I do not see any 249 in the list of colours defined in Windows. If it is an issue, then it would not be defined as the default window colour of Windows. Those who have issues with it would have the same issues with many other apps and should use a different solution.

@JeromeMartinez
Copy link
Member

So far I have been setting colours using the GUI form editor and do not know/want to write codes for that.

I'll give it a try. Not keen of 255.

@JeromeMartinez JeromeMartinez merged commit 1638a28 into MediaArea:master Nov 13, 2024
3 checks passed
@JeromeMartinez JeromeMartinez linked an issue Nov 13, 2024 that may be closed by this pull request
@cjee21 cjee21 deleted the text-view branch November 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] Revert back themes and text sheme
2 participants