Fix signup notifications for deleted accounts #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
bug
BentiGorlich
force-pushed
the
dev/new_features
branch
from
6bae56c to
7d164b1
Compare
BentiGorlich
force-pushed
the
fix/signup-notifications-for-deleted-accounts
branch
from
aa3aeef to
784c58a
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
7d164b1 to
c6e6807
Compare
BentiGorlich
force-pushed
the
fix/signup-notifications-for-deleted-accounts
branch
from
784c58a to
f1f311e
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
c6e6807 to
5d0bccd
Compare
BentiGorlich
force-pushed
the
fix/signup-notifications-for-deleted-accounts
branch
from
f1f311e to
7836226
Compare
Admins shouldn't get notifications when an account is created as a deleted account. This happens when we delete users, as a new user is created with deleted set to true to block the username
BentiGorlich
force-pushed
the
dev/new_features
branch
from
5d0bccd to
07d0603
Compare
BentiGorlich
force-pushed
the
fix/signup-notifications-for-deleted-accounts
branch
from
7836226 to
39a89a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins shouldn't get notifications when an account is created as a deleted account. This happens when we delete users, as a new user is created with deleted set to true to block the username