Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM warnings, round 2 #1332

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Fix NPM warnings, round 2 #1332

merged 6 commits into from
Dec 30, 2024

Conversation

garrettw
Copy link
Contributor

Continuation of #1329 but with an extra bugfix

@melroy89 melroy89 self-requested a review December 30, 2024 01:40
"type: module" in package.json seems to break too much stuff so instead, explicitly specify that the eslint config is a module and leave everything else alone.
@garrettw garrettw marked this pull request as ready for review December 30, 2024 03:20
@garrettw
Copy link
Contributor Author

@melroy89 I have confirmed that the prior issues are now fixed.

@garrettw garrettw added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code and removed dependencies Pull requests that update a dependency file labels Dec 30, 2024
@melroy89
Copy link
Member

Yup everything seems to work this time :)

@garrettw garrettw merged commit fd94b63 into main Dec 30, 2024
7 checks passed
@garrettw garrettw deleted the npm-deps branch December 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants