[Feature] Custom notification settings #1272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
074b8c7 to
a2e5b9b
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
c1aba40 to
eaa3390
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
a2e5b9b to
65f9bbe
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
e05d4f2 to
6bae56c
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
65f9bbe to
07863d2
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
6bae56c to
7d164b1
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
77ba641 to
e88753b
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
7d164b1 to
c6e6807
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
e88753b to
1d6efed
Compare
BentiGorlich
force-pushed
the
dev/new_features
branch
from
c6e6807 to
5d0bccd
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
1d6efed to
fecc14a
Compare
You can now set custom notification settings for users, magazine, entries and posts: `Loud`, `Default` or `Muted`. Move the logic of "fetch an endpoint and get html. Replace html node with selector x with the result of the fetch" to another controller, so it can be used outside of subjects (`Entry`, `EntryComment`, `Post` and `PostComment`)
- if the magazine was not on default (e.g.: on loud) and you had "notify on replies" enabled it didn't work -> fix that - rename some variables for readability - add log statement with all the variables
BentiGorlich
force-pushed
the
dev/new_features
branch
from
5d0bccd to
07d0603
Compare
BentiGorlich
force-pushed
the
new/custom-notification-settings
branch
from
fecc14a to
905071b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set custom notification settings for users, magazine, entries and posts:
Loud,DefaultorMuted.The heart of the logic is in the method
NotificationSettingsRepository::findNotificationSubscribersByTargetwhich replaced some logic in the notification managers.The logic works in tiers:
So if you muted the magazine and thread, but the author is set to "Loud" then you will still get notifications for threads created by them.
If you muted the user, but set the magazine to "Loud" then you will get notifications for threads that are not created by that muted user.