Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make legacy declarations private: macro guard, cipher #9868

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Make legacy declarations private: macro guard, cipher #9868

wants to merge 3 commits into from

Conversation

gilles-peskine-arm
Copy link
Contributor

See Mbed-TLS/TF-PSA-Crypto#132.

Remove sample programs for the legacy API.

This is up for design review. Some open items:

  • Changelog entries for removed sample programs?
  • File tasks (not critical for 4.0) to update programs that now use private access.

PR checklist

  • changelog provided | not required because:
  • development PR here
  • framework PR not required
  • 3.6 PR not required because: new stuff
  • 2.28 PR not required because: new stuff
  • tests provided

@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Dec 23, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 23, 2024
Open
3 tasks
@gilles-peskine-arm
Remove sample programs for the legacy cipher API
37065ee 
These programs illustrate the legacy cipher API, which is being removed.
They are not particularly interesting and there is no straightforward
translation to PSA.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm
Allow ssl_context_info and benchmark to use private functions
44b30cc 
Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm
Update submodule
e14b84b 
* New macro `MBEDTLS_DECLARE_PRIVATE_IDENTIFIERS` in `mbedtls/private_access.h`.
* Make `mbedtls/cipher.h` functions private.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm force-pushed the private-declarations-prototype-4.0 branch from 6923b47 to e14b84b Compare December 23, 2024 15:58
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: To Do
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gilles-peskine-arm