-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faketime package #108
Add faketime package #108
Conversation
This is prepare for checking data_files Signed-off-by: Jerry Yu <[email protected]>
I tried to build docker image local . apt command pass, but it fails at get DS5. |
We can no longer build the arm-compilers image, until we find a new way to download DS5 automatically. We rely on having the built image cached. We can still extend it, but only after the DS5 download stage (when rebuilding, the system will continue from the intermediate stage it has in cache). But we don't need faketime in that image anyway: we're only using it to do builds, not run tests. |
@@ -89,6 +89,8 @@ RUN apt-get update -q && apt-get install -yq \ | |||
zlib1g \ | |||
# to build Mbed TLS with MBEDTLS_ZILIB_SUPPORT (removed in 3.0) | |||
zlib1g-dev \ | |||
# to run tests in specific time. | |||
faketime \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the list in alphabetical order, it helps when looking at what's there.
Signed-off-by: Jerry Yu <[email protected]>
Does that mean I should put it after arm compilers? |
No: just don't change the |
Got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on code reading. I've started test jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is prepare for checking data_files
That script will run test with faketime
Test jobs on 6d32bea (running just Linux tests, since there are only Docker file updates):