Add basic miscellaneous components to TF-PSA-Crypto #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
2 times, most recently
from
488c9e7 to
ae2c007
Compare
3 tasks
Harry-Ramsey
added
enhancement
ronald-cron-arm
requested changes
Jan 13, 2025
There was a problem hiding this comment.
This looks good to me but I think I missed in the first place the component check_test_helpers (now in .#53 description). Please add it as well.
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
from
ae2c007 to
b44f627
Compare
Added |
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
3 times, most recently
from
4d3ac6e to
2896fb3
Compare
ronald-cron-arm
requested changes
Jan 17, 2025
This commit adds basic miscellaneous components to TF-PSA-Crypto. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
from
2896fb3 to
5247172
Compare
6 tasks
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
3 times, most recently
from
a047475 to
206c629
Compare
valeriosetti
previously approved these changes
Jan 17, 2025
Update framework submodule to contain moved files necessary for components-sanitizers. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
components-basic-checks-development
branch
from
206c629 to
77654b4
Compare
valeriosetti
approved these changes
Jan 17, 2025
ronald-cron-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic miscellaneous components to TF-PSA-Crypto. Closes #53.
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: