Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check files component #133

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add check files component #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5966e5d
Add check_files component
Harry-Ramsey Dec 27, 2024
2c01684
Update framework for check_files.py
Harry-Ramsey Dec 27, 2024
a320a4b
Add check python files component
Harry-Ramsey Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework
Open in desktop
Submodule framework updated 9 files
+4 −4 data_files/.gitignore
+1 −1 scripts/all-core.sh
+5 −4 scripts/check_files.py
+3 −3 scripts/mbedtls_framework/build_tree.py
+1 −1 scripts/mbedtls_framework/code_wrapper/psa_wrapper.py
+12 −12 scripts/mbedtls_framework/psa_information.py
+9 −14 scripts/mbedtls_framework/psa_storage.py
+9 −4 scripts/mbedtls_framework/psa_test_case.py
+40 −0 scripts/pkgconfig.sh
20 changes: 20 additions & 0 deletions tests/scripts/components-basic-checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# components-basic-checks.sh
#
# Copyright The Mbed TLS Contributors
# SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later

# This file contains test components that are executed by all.sh

################################################################
#### Basic checks
################################################################

component_tf_psa_crypto_check_files () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The originating issue says we need 2 new components: component_tf_psa_crypto_check_files (added here) and component_tf_psa_crypto_check_python_files which I cannot find anywhere in the repo. Just to be sure, was it intentional to skip the 2nd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it was edited since I last saw it. Let me add a new component for check_python_files.

msg "Check: file sanity checks (permissions, encodings)" # < 1s
$FRAMEWORK/scripts/check_files.py
}

components_tf_psa_crypto_check_python_files () {
msg "Lint: Python scripts"
$FRAMEWORK/scripts/check-python-files.sh
}