Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass the size we are checking for validity #159

Merged
merged 1 commit into from
Jan 14, 2024
Merged

pass the size we are checking for validity #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion matroska/KaxBlock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ class MATROSKA_DLL_API KaxInternalBlock : public libebml::EbmlBinary {
{}
KaxInternalBlock(const KaxInternalBlock & ElementToClone);
~KaxInternalBlock() override;
bool ValidateSize() const override;
bool SizeIsValid(std::uint64_t size) const override
{
return size >= 4; /// for the moment
}

std::uint16_t TrackNum() const {return TrackNumber;}
/*!
Expand Down
5 changes: 0 additions & 5 deletions src/KaxBlock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ SimpleDataBuffer::SimpleDataBuffer(const SimpleDataBuffer & ToClone)
bValidValue = ToClone.bValidValue;
}

bool KaxInternalBlock::ValidateSize() const
{
return (GetSize() >= 4); /// for the moment
}

KaxInternalBlock::~KaxInternalBlock()
{
ReleaseFrames();
Expand Down