Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing/forced libebml namespace #288

Merged
merged 2 commits into from
Mar 2, 2024
Merged

fix missing/forced libebml namespace #288

merged 2 commits into from
Mar 2, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Mar 2, 2024

No description provided.

@robUx4 robUx4 added the api-break breaks the API (e.g. programs using it will have to adjust their source code) label Mar 2, 2024
@robUx4
don't force the base class to be a libebml class
97b6cc0 
We can use DEFINE_xxx_CLASS_BASE macros for other classes.
@mbunkus mbunkus merged commit d4808b9 into Matroska-Org:master Mar 2, 2024
17 checks passed
@robUx4 robUx4 deleted the ns_fixes branch March 3, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus