Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom division #273

Closed
wants to merge 12 commits into from
Closed

Conversation

rheiland
Copy link
Collaborator

Provide functionality for custom cell division (a new functions.cell_division_function), plus lineage tracking via generation and parentID attributes for agents.

Copy link
Collaborator

@drbergman drbergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited for this! There's also some changes on where the PhysiCell_constants are defined. Is that related? Or solving some other issue?

@@ -890,6 +890,29 @@ void add_PhysiCell_cells_to_open_xml_pugi_v2( pugi::xml_document& xml_dom, std::
data_start_indices.push_back( index );
cell_data_size += size;
index += size;

// generation
name = "generation";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when merging with dev-paul, will need (or maybe just want?) to update these with Paul's condensed version of this code there

@rheiland
Copy link
Collaborator Author

Really excited for this! There's also some changes on where the PhysiCell_constants are defined. Is that related? Or solving some other issue?

This is one reason I've been having mild panic attacks lately :-) over the upcoming merge party. I think I made this branch from my branch which dealt with #248 (I had reasons for doing so at the time). So this touches on merging PRs in a certain order, I think. Or, I could simply update the branch for custom cell division and use the original "constants" code.

@rheiland
Copy link
Collaborator Author

Earlier comments about this PR are in the related Issue #269

@rheiland
Copy link
Collaborator Author

Closing. The actual custom function for cell division was merged with #285. Perhaps later we can refer to this 273 for an improved cell lineage tracking PR.

@rheiland rheiland closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants