-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify optimade versioning #441
Merged
merkys
merged 5 commits into
Materials-Consortia:develop
from
rartino:clarify_optimade_versioning
Dec 22, 2022
Merged
Clarify optimade versioning #441
merkys
merged 5 commits into
Materials-Consortia:develop
from
rartino:clarify_optimade_versioning
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rartino
commented
Dec 20, 2022
ml-evs
previously approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rartino, this reads well to me.
vaitkus
reviewed
Dec 20, 2022
merkys
reviewed
Dec 20, 2022
Co-authored-by: Andrius Merkys <[email protected]> Co-authored-by: Antanas Vaitkus <[email protected]>
merkys
approved these changes
Dec 21, 2022
Pinging @ml-evs on a quick revist on this as well. |
ml-evs
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested in the release planning for v1.2 #429 that we clarify how semantic versioning applies to the versioning of the OPTIMADE standard. I've made my best attempt to be as clear as possible on what I believe is/should be our policy.