-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New biomol fields #400
Open
d-beltran
wants to merge
23
commits into
Materials-Consortia:develop
Choose a base branch
from
d-beltran:iss389_biomol
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−0
Open
New biomol fields #400
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eca24df
added new biomol fields
d-beltran 572a29f
added new biomol sequence fields
d-beltran 173172f
Update optimade.rst
d-beltran 5911d53
Title underlines fit
d-beltran 05a8fed
More explained biomol_chain types
d-beltran 76f690c
Added standard labels for biomol_chain types
d-beltran 1f5650d
Added underscore to new fieldnames
d-beltran a8781ac
Amend
d-beltran ac6ed65
New species property: biomol atom name
d-beltran 55f71e2
Restructured biomol sequences
d-beltran 534ec8d
Merge branch 'develop' into iss389_biomol
d-beltran f865a5a
Laussane discussions update
d-beltran af3c817
Update optimade.rst
d-beltran 616019c
Update optimade.rst
d-beltran bd3e9e1
Update optimade.rst
d-beltran ce93c9d
Update optimade.rst
d-beltran a875aaf
added a few breaklines with correct indent
d-beltran a1ddd88
Update optimade.rst
d-beltran a0ee16a
Update optimade.rst
d-beltran c0ea1ac
Update optimade.rst
d-beltran af14d72
Update optimade.rst
d-beltran 7610146
insertion_code renamed as icode
d-beltran c38075c
Merge branch 'develop' into iss389_biomol
rartino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean when
chain
is missing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may happen in a regular PDB file that the chain column is blank and this is not necessarily wrong. I don't think there is any physical or chemical meaning. Chains are something very custom and there is not a strict criteria for setting them.
In our database when chains are missing we set them automatically using a chain per fragment logic but this is just to have the data standardized. Some tools just set all atoms belonging to chain 'X' and some tools simply respect that and let the structure without chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explanation. But maybe then it would make sense to make
) as its value?
chain
mandatory and faithfully retain the space character (There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it also works to me.
We also talked about not getting constrained by the limits of PDB format regarding the 1 character string in the chain name, so the missing chain could also be 'Not defined', '', null or many others. As you prefer.