storage: flatten StorageCommand and StorageResponse
#31261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
flatten-storage-command-response
branch
from
58bd1a6 to
6a9c057
Compare
Signed-off-by: Petros Angelatos <[email protected]>
teskje
approved these changes
Feb 6, 2025
| self.pending_table_handle_drops_tx | ||
| .send(dropped_id) | ||
| .expect("ourselves are not dropped"); | ||
| if !self.pending_table_handle_drops_rx.is_empty() { |
Comment on lines
+1891
to
+1893
| // Take the allocation so that we can call mut receiver functions in the loop. We put it | ||
| // back at the end of the loop. | ||
| let mut stashed_responses = std::mem::take(&mut self.stashed_responses); |
There was a problem hiding this comment.
Maybe we shouldn't? If we drop the allocation instead, we don't have to worry about it ever getting large. Keeping it lets us safe some allocation overhead, but is that really relevant in this code?
| updated_frontiers = Some(Response::FrontierUpdates(updates)); | ||
| StorageResponse::FrontierUpper(id, upper) => { | ||
| let update = (id, upper); | ||
| self.update_write_frontiers(std::slice::from_ref(&update)); |
There was a problem hiding this comment.
Looks like Controller::update_write_frontiers is now only called with a single update everywhere, so you could rename it to update_write_frontier and remove its loop.
| /// A list of statistics updates, currently only for sources. | ||
| StatisticsUpdates(Vec<SourceStatisticsUpdate>, Vec<SinkStatisticsUpdate>), | ||
| /// A list of status updates for sources and sinks. Periodically sent from | ||
| /// A status updates for a source or a sink. Periodically sent from |
There was a problem hiding this comment.
Suggested change
| /// A status updates for a source or a sink. Periodically sent from | |
| /// A status update for a source or a sink. Periodically sent from |
| @@ -146,7 +145,7 @@ impl<T> StorageCommand<T> { | |||
| | InitializationComplete | |||
| | AllowWrites | |||
| | UpdateConfiguration(_) | |||
| | AllowCompaction(_) => false, | |||
| | AllowCompaction(_, _) => false, | |||
There was a problem hiding this comment.
Did you know you can use .. on tuple variants too? Not important at all, but I found this neat when I learned about it :)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Each commit flattens one variant
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.