-
Notifications
You must be signed in to change notification settings - Fork 6
Added an option to unauthorize all previously authotized users. #18
base: master
Are you sure you want to change the base?
Conversation
Hello @xredo , I added an option to clear organization's authorizations. Our multitenant clients need this option and I thought it could be interesting to somebody else... |
Hi @operez-ddgi Thank you for opening the PR. We are waiting to merge the PR #19 that updates the gem to the latest Decidim version to start this review. After we merge #19 we are planning to support different Decidim versions with this gem. Please, let us know if there is any problem with it. |
Hi @operez-ddgi. We have merged #19 to master. Can you rebase your branch with paster and push again, please? |
…ll be useful when clearing census data Clear authorizations now only for current organization Corrected spacs problem Updated Decidim dependency version Moved clear authorizations action to its own method Removed trailing whitespace removed whitespaces and tabs Uncommented lines and corrected whitespaces Corrected indentation Removed trailing whitespace Corrected whitespaces and removed unnecessary code Added a final newline Added a final newline Resolved conflicts Resolved conflicts Solved conflicts
4ee84ea
to
a2967d2
Compare
Hi @artero , I just rebased this PR. Thank-you very much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments. Could you review them and tell me what do you think? Thanks for the PR!
app/views/decidim/file_authorization_handler/admin/censuses/show.html.erb
Outdated
Show resolved
Hide resolved
app/controllers/decidim/file_authorization_handler/admin/censuses_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/decidim/file_authorization_handler/admin/censuses_controller.rb
Outdated
Show resolved
Hide resolved
Hi @artero , I reviewed all your comments and pushed a new version. Could you please check it again? Thank-you very much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple minor comments.
Thank you so much for the PR.
config/locales/en.yml
Outdated
@@ -1,45 +1,46 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you remove this line, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops! This line shbould not be there! Thank-you for pointing it!
Thank-you very much @artero for your reviews. Now I corrected these errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much.
It will be useful when clearing census data.
In current master branch when a user gets authorized it is authorized for live. If he leaves town he can still participate in areas where maybe he should not.
With this option a checkbox appears on the upload census screen allowing the admin to remove all previous authorizations.