Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set missing Longer LK & U20 SDIO define #1117

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

tpruvot
Copy link
Contributor

@tpruvot tpruvot commented Nov 2, 2024

In the past (pre 2.1.2.1) we had a define SDIO_SUPPORT which was not replaced by ONBOARD_SDIO in the config samples nor the pins.h

so #define SDCARD_CONNECTION ONBOARD which do the job

@thinkyhead
Copy link
Member

It looks like the only options would be ONBOARD and CUSTOM_CABLE since there's no standard SPI LCD/SD wiring specified. The board may be used in any machine, so ONBOARD is a sensible default when SDSUPPORT is enabled. So, should we (also) add this to pins_LONGER_LK.h? :

#ifndef SDCARD_CONNECTION
  #define SDCARD_CONNECTION              ONBOARD
#endif

@thinkyhead thinkyhead merged commit 5788bc7 into MarlinFirmware:import-2.1.x Nov 3, 2024
1 check passed
@tpruvot
Copy link
Contributor Author

tpruvot commented Nov 3, 2024

The only SPI thing on this board is the eeprom, used to store some icons for the original UI, not at all in Marlin. The only way to use SPI is to unsolder the eeprom SMD chip so i guess we can even force ONBOARD_SDIO in pins_LONGER_LK.h for this one.

@tpruvot
Copy link
Contributor Author

tpruvot commented Nov 3, 2024

To note : this board is one of the few ones with dedicated TFT pins only present on F103V and F103Z chips. Its not a SPI LCD

rngkll pushed a commit to rngkll/Configurations that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants