Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatenotification: update_helper.js recode with pm2 library (v2.27.x) #3332

Merged
merged 9 commits into from
Jan 20, 2024

Conversation

bugsounet
Copy link
Contributor

@bugsounet bugsounet commented Jan 3, 2024

#3285

Because there is so many conflit with package,
I have rewrite the code with v2.27.0-develop

For remember:

  • recode: update_helper.js with pm2 library
  • fix: default config -> updates is a array
  • delete: command-exists library (not used)
  • delete: PM2_GetList() function (not used)
  • add: check updates.length (prevent crash)
  • add: [PM2] tag in log (for better visibility)
  • add: pm2 library

advantage:

  • we use the pm2 library directly
  • avoids weird returns from child_process.exec when requesting a json format from pm2
  • simplified the code

inconvenient:

  • we have vulnerabilities with axios

240120 Fix:

  • use pm2_env.pm_cwd instead of pm2_env.PWD : prevent using pm2 restart <id> --update-env in other directory (for enable GPU rendering for exemple)
  • resolve packages (again)

@bugsounet bugsounet changed the base branch from master to develop January 3, 2024 19:01
@bugsounet
Copy link
Contributor Author

bugsounet commented Jan 12, 2024

Testing and correct some new part of code (new dependency format)

@rejas should i remove the exception of dependency ?

Notes:

  • axios vulnerabilities from @pm2/js-api is ignored
  • we don't use @pm2/js-api

@rejas
Copy link
Collaborator

rejas commented Jan 14, 2024

I actually like the allow-ghsas solution which can stay there as long as the dependabot vulanribility is there.

@bugsounet bugsounet marked this pull request as ready for review January 20, 2024 12:04
@bugsounet
Copy link
Contributor Author

if it's ok for you, it's ok for me ;)

@rejas rejas merged commit c96ced9 into MagicMirrorOrg:develop Jan 20, 2024
6 checks passed
@bugsounet bugsounet deleted the pm2_updatenotification branch January 20, 2024 20:48
@rejas rejas mentioned this pull request Apr 1, 2024
rejas added a commit that referenced this pull request Apr 1, 2024
## [2.27.0] - 2024-04-01

Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser,
@khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and
@vppencilsharpener.

This release marks the first release without Michael Teeuw (@MichMich).
A very special thanks to him for creating MagicMirror and leading the
project for so many years.

For more info, please read the following post: [A New Chapter for
MagicMirror: The Community Takes the
Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead).

### Added

- Output of system information to the console for troubleshooting (#3328
and #3337), ignore errors under aarch64 (#3349)
- [chore] Add `eslint-plugin-package-json` to lint the `package.json`
files (#3368)
- [weather] `showHumidity` config is now a string describing where to
show this element. Supported values: "wind", "temp", "feelslike",
"below", "none". (#3330)
- electron-rebuild test suite for electron and 3rd party modules
compatibility (#3392)
- Create MM² icon and attach it to electron process (#3407)

### Updated

- Update updatenotification (update_helper.js): Recode with pm2 library
(#3332)
- Removing lodash dependency by replacing merge by spread operator
(#3339)
- Use node prefix for build-in modules (#3340)
- Rework logging colors (#3350)
- Update pm2 to v5.3.1 with no allow-ghsas (#3364)
- [chore] Update husky and let lint-staged fix ESLint issues
- [chore] Update dependencies including electron to v29 (#3357) and
node-ical
- Update translations for estonian (#3371)
- Update electron to v29 and update other dependencies
- [calendar] fullDay events over several days now show the left days
from the first day on and 'today' on the last day
- Update layout of current weather indoor values

### Fixed

- Correct apibase of weathergov weatherprovider to match documentation
(#2926)
- Worked around several issues in the RRULE library that were causing
deleted calender events to still show, some
initial and recurring events to not show, and some event times to be off
an hour. (#3291)
- Skip changelog requirement when running tests for dependency updates
(#3320)
- Display precipitation probability when it is 0% instead of blank/empty
(#3345)
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1
active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper
function (#3336)
- Ignore all custom css files (#3359)
- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361)
- Changed `log.debug` to `log.log` in `app.js` where logLevel is not set
because config is not loaded at this time (#3353)
- [calendar] deny fetch interval < 60000 and set 60000 in this case
(prevent fetch loop failed) (#3382)
- added message in case where config.js is missing the module.export
line PR #3383
- Fixed an issue where recurring events could extend past their
recurrence end date (#3393)
- Don't display any `npm WARN <....>` on install (#3399)
- Fixed move suncalc dependency to production from dev, as it is used by
clock module
- [compliments] Fix mirror not responding anymore when no compliments
are to be shown (#3385)

### Deleted

- Unneeded file headers (#3358)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Michael Teeuw <[email protected]>
Co-authored-by: Kristjan ESPERANTO <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <[email protected]>
Co-authored-by: Ross Younger <[email protected]>
Co-authored-by: Bugsounet - Cédric <[email protected]>
Co-authored-by: jkriegshauser <[email protected]>
Co-authored-by: illimarkangur <[email protected]>
Co-authored-by: sam detweiler <[email protected]>
Co-authored-by: vppencilsharpener <[email protected]>
Co-authored-by: Paranoid93 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants