Week 4 - Yang Wang #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
requested changes
Feb 25, 2019
|
|
||
| /* ===================== | ||
| Now that you've properly parsed your data, use _.each to plot the | ||
| dataset you've pulled down. | ||
| ===================== */ | ||
| _.each(crimelist, function(data) {L.marker([data.Lat, data.]) |
There was a problem hiding this comment.
Missing something after data.
| @@ -103,12 +105,17 @@ var phillyBikeCrashesDataUrl = "https://raw.githubusercontent.com/CPLN692-MUSA61 | |||
| Remember to call all code within the function body. Use console.log to make sure | |||
| that this step is completed before moving on! | |||
| ===================== */ | |||
|
|
|||
| $.ajax(phillyCrimeDataUrl).done(function(ajaxResponseValue) { | |||
| var crimelist = JSON.parse(ajaxResponseValue); | |||
There was a problem hiding this comment.
Does this load data on to the map for you?
You need to define crimelist outside of the ajax call so it can be stored out of scope of the function and referred to later
| @@ -42,6 +44,22 @@ var getAndParseData = function() { | |||
| /* ===================== | |||
| Fill out this function definition | |||
| ===================== */ | |||
| dat = $.ajax("https://raw.githubusercontent.com/CPLN692-MUSA611/datasets/master/json/philadelphia-crime-snippet.json";).done( | |||
There was a problem hiding this comment.
It looks like you are copying a dataset from a previous years class.
Furthermore, this does not successfully run for me.
Does it for you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.