Posthog tracker #1102
Merged
Posthog tracker #1102
+98
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicguillois
force-pushed
the
posthog-tracker
branch
from
7ce52f6 to
7dc0fed
Compare
Falinor
reviewed
Jan 22, 2025
| data-testid="filtre-sous-statut-suivi" | ||
| onChange={(values) => { | ||
| onChangeFilters({ subStatus: values }, 'Sous-statut'); | ||
| posthog.capture('filtre-sous-statut-suivi'); |
There was a problem hiding this comment.
Pourquoi il faut le faire manuellement alors qu’on le faisait automatiquement avec des id ?
There was a problem hiding this comment.
ça ne fonctionnait pas, j'ai testé en activant posthog en local, les XHR sont bien envoyés vers posthog avec cette approche
frontend/src/components/HousingListFilters/HousingListFiltersSidemenu.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/HousingListFilters/HousingListFiltersSidemenu.tsx
Outdated
Show resolved
Hide resolved
| data-testid="filtre-type-de-commune" | ||
| onChange={(values) => { | ||
| onChangeFilters({ localityKinds: values }, 'Type de commune'); | ||
| posthog.capture('filtre-commune'); |
There was a problem hiding this comment.
Pourquoi il y a deux filtre-commune ?
There was a problem hiding this comment.
c'est corrigé, initialement je pensais que Lucas voulais regrouper les événements statistiques liés à ces deux filtres mais c'était une erreur
frontend/src/components/HousingListFilters/HousingListFiltersSidemenu.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/HousingListFilters/HousingListFiltersSidemenu.tsx
Outdated
Show resolved
Hide resolved
loicguillois
force-pushed
the
posthog-tracker
branch
from
39f743f to
2ab25e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.