Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files from m65263. preselections. Fraunhofer IIS #122

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

podborski
Copy link
Member

No description provided.

@podborski podborski added the conformance-file This initiates file feature extraction on PRs label Oct 19, 2023
@mfuchs-iis
Copy link
Collaborator

It seems like the automation scripts are overwriting the GPAC JSON I generated with a patched GPAC that understands the preselection signaling. Is there a way to keep the automation from re-generating the JSON files if they are already contained in a commit?

@DenizUgur
Copy link
Collaborator

Yes, please add manualDump: true to your GPAC output. It has to be on the root level

@mfuchs-iis
Copy link
Collaborator

mfuchs-iis commented Oct 26, 2023

Thanks for the quick reply!
Could we maybe add a parameter to the 'contribute-files' script that automatically adds the 'manualDump' field to the JSON output s.t. people don't need to manually patch it after running the script?

@cconcolato cconcolato added the cross checked An independent review of the files has been done and streams have been verified as valid. label Jan 23, 2024
@cconcolato
Copy link
Contributor

Initially reviewed by Dolby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance-file This initiates file feature extraction on PRs cross checked An independent review of the files has been done and streams have been verified as valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants