Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the new static information: BNU soil types and 15" MODIS landuse #1252

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

tanyasmirnova
Copy link

@tanyasmirnova tanyasmirnova commented Dec 12, 2024

The BNU soil dataset has the same soil categories as in STATSGO with differences in spatial variations.
The MODIFIED_IGBP_MODIS_NOAH_15s has the same categories as in MODIFIED_IGBP_MODIS_NOAH.
The additional static information is introduced via the namelist.init_atmosphere
config_landuse_data = 'MODIFIED_IGBP_MODIS_NOAH_15s'
config_soilcat_data = 'BNU'

@@ -137,6 +137,11 @@
description="The number of months in a year"
possible_values="Positive integer values"/>

<nml_option name="config_nsoilcat" type="integer" default_value="16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like config_nsoilcat is used anywhere, so it seems like we could remove it from this PR branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgduda Mike, this variable will be used in the following PRs that will compute the fractional content of soil types in each grid cell. And the 3-d array of fractional soil types will be dimensioned as nsoilcat.

@@ -213,11 +215,13 @@ subroutine init_atm_static(mesh, dims, configs)

call mpas_pool_get_config(configs, 'config_geog_data_path', config_geog_data_path)
call mpas_pool_get_config(configs, 'config_landuse_data', config_landuse_data)
call mpas_pool_get_config(configs, 'config_soilcat_data', config_soilcat_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the definition of config_soilcat_data is missing from the Registry.xml file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mike, sorry about that. I added config_soilcat_data to the Registry.xml

@@ -191,9 +196,14 @@
description="The supersampling factor to be used for MODIS maximum snow albedo and monthly albedo datasets (case 7 only)"
possible_values="Positive integer values"/>

<nml_option name="config_supersample_fac_lu" type="integer" default_value="1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an idea, what if we called this config_lu_supersample_factor? That name would match the pattern set by the two existing super-sampling options nicely: config_supersample_factor, config_lu_supersample_factor, and config_30s_supersample_factor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the idea. The name is changed as you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants