Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template after relicensing #4860

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update PR template after relicensing #4860

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73c6c06
update
RMeli Dec 22, 2024
d5fef31
improvements
RMeli Jan 8, 2025
40e797b
ialibay comments
RMeli Jan 26, 2025
829c112
Merge branch 'develop' into relicensing-is-over
RMeli Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,28 @@
<!--
Insert issue number that this PR fixes (if any) just after 'Fixes #'.
If this PR does not fix an existing issue, consider opening one or remove 'Fixes #' from the PR description.
-->
Fixes #

Changes made in this Pull Request:
-
<!-- Describe the changes that this PR makes. If applicable, use the following bullet list. -->
-


PR Checklist
------------
- [ ] Tests?
- [ ] Docs?
- [ ] CHANGELOG updated?
## PR Checklist
<!-- Please use the following checklist to ensure the PR is ready to be reviewed/merged. -->
- [ ] Issue raised/referenced?
RMeli marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Tests updated/added?
- [ ] Documentation updated/added?
- [ ] `package/CHANGELOG` file updated?
- [ ] Is your name in `package/AUTHORS`? (If it is not, add it!)

## Developers Certificate of Origin
<!--
CHECKING THE FOLLOWING BOX (BY ADDING 'x' INSIDE THE BRACKETS `[x]`) IS MANDATORY FOR ALL PRs.
RMeli marked this conversation as resolved.
Show resolved Hide resolved
-->

In order for this PR to be merged you **must certify that you are able to submit your code to be included in MDAnalysis**. Read the links and then check the box if you agree.

Code in MDAnalysis is under [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE).
RMeli marked this conversation as resolved.
Show resolved Hide resolved

## Developers certificate of origin
- [ ] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE) and adheres to the [**Developer Certificate of Origin**](https://developercertificate.org/).
Comment on lines -14 to -15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing.

@IAlibay , your opinion is also important here – can you please weigh in?

- [ ] I certify that I can legally submit this code contribution as described in the [**Developer Certificate of Origin**](https://developercertificate.org/)
RMeli marked this conversation as resolved.
Show resolved Hide resolved
Loading