-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of WaterSelection
for water resiude selection
#4854
Conversation
Addition of WaterSelection
added tests
changelog addition mentioned
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4854 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21779 22854 +1075
Branches 3064 3064
===========================================
+ Hits 20398 21400 +1002
- Misses 929 1002 +73
Partials 452 452 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Looks good to me, and something we need.
Fixes #4839 through the addition of the
water
token.Changes made in this Pull Request:
WaterSelection
class with thewater
token to select water residuesTestSelectionsWater
with tests to coverwater
token intest_atomselections.py
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4854.org.readthedocs.build/en/4854/