-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 85.85% 88.33% +2.47%
==========================================
Files 6 8 +2
Lines 99 120 +21
==========================================
+ Hits 85 106 +21
Misses 14 14 ☔ View full report in Codecov by Sentry. |
c8a00ea
to
76b17ae
Compare
Rationale behind removing
|
f8a0437
to
1ca2efe
Compare
So how would you recommend computing the output size cheaply? |
For |
That's my point, don't we need this function on every layer as part of the interface? |
Do you mean make it mandatory to define |
I don't see how else to support static analyses |
Having a way to specify the layer size could also help for things like I recall trying the 3 arg version to determine the |
I think that is a plausible suggestion. We already reserve "name", so I don't see why we can't extend that to reserving
Do you need to run symbolic tracing? Something like the flux version can be implemented with specific overloads for common Lux operations. Essentially take a Symbolic Array, convert it to a |
@SebastianM-C here is a Lux version LuxDL/Lux.jl#811 which should be cheap to run to get the sizes. |
I'd rather avoid that if there's a better solution.
Thanks, let me see what I can do. |
9c9c06e
to
17566de
Compare
The From the tests, almost all networks should work (the only exceptions being, if the element types aren't |
8ab1e33
to
946f3c9
Compare
This changelog needs to be put in Lux. I will copy it over later.
merge after #42
Changelog
AbstractExplicit...
names have been changed toAbstractLux...
.Functors.jl
andSetfield.jl
are non-essential dependencies and have been moved into extensions.inputsize
since that wasn't being used anywhere.outputsize
is no longer supported.outputsize
is now only defined once Lux.jl is loadedAbstractLuxContainerLayer{(:a,)}
wraps theinitialparameters
andinitialstates
with a NamedTuple with a single fielda
.AbstractLuxWrapperLayer
.