Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate DDIM to Reactant #1158

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: migrate DDIM to Reactant #1158

wants to merge 7 commits into from

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jan 3, 2025

Note we definitely need a new EnzymeJAX tag and a bunch of optimizations to go through before this can be run with the best performance

@avik-pal
Copy link
Member Author

avik-pal commented Jan 5, 2025

This one definitely needs me to implement the loop using @trace else it takes forever to compile the generate function

@avik-pal avik-pal force-pushed the ap/ddim branch 2 times, most recently from f4878bd to 08baf9b Compare January 24, 2025 02:54
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Benchmark Results (ASV)

main b2e5e6e... main/b2e5e6e8f83eda...
basics/overhead 0.135 ± 0.0016 μs 0.128 ± 0.0021 μs 1.05
time_to_load 0.888 ± 0.0027 s 0.904 ± 0.026 s 0.982

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant