Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.fancyform.js #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilkarolak
Copy link
Contributor

Now you can have onlu one call for transforming select's and you can set every select width separately by setting width of transformed select. Ex: Option 1Option 2

Now you can have onlu one call for transforming select's and you can set every select width separately by setting width of transformed select. Ex: <select name="select" id="select" style="width: 200px;"><option value="0">Option 1</option><option value="1">Option 2</option></select>
@tsukasa1989
Copy link
Member

Thanks for the pull. But there is an issue with this pull.

What will hapen if someone does not set the width: 100px;? Than it still will overwrite the CSS width property, so this will give some issues with using CSS width on elements. For example this won't work anymore:

.transformSelect{ width: 200px; } 

Will not be 200px if you do not use inline SELECT width. Also if an element is hidden, not every browser is able to get the width of an element. so t.width() will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants