Fix: Check timeInForce exists on Kraken API response.

[WilliamWhispell]

I was trying to submit buy/sell on DOGE and to then check the order completed. I ran into two issues.

1. timeInForce was None on existing open orders. These were created with Bitsgap and the parse code in ccxt.py assumes the key will exist, but it does not from Kraken for me on some orders.
2. when querying for closed orders the fetch to kraken API fails, I'm not fetching with margin, so I removed the dict as an arg to the api fetch and it works... I'm not sure where the API code for kraken is, possibly this part of the change could be done differently.

This change allows me to submit orders to kraken and check the status of orders.

Description by Korbit AI

What change is being made?

Modify the CCXT broker in the Lumibot project to handle potential absence of the timeInForce key in the Kraken API response and ensure no parameters are sent for closed orders when the exchange is Kraken.

Why are these changes being made?

These changes address two issues: preventing errors when timeInForce is missing in the Kraken API responses by safely checking its existence, and adhering to Kraken's requirements by refraining from sending additional parameters for closed orders which can cause the requests to fail. These adjustments improve compatibility with Kraken's API.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[korbit-ai]

Important

Required App Permission Update

Noise Reduction Improvements

This update requests write permissions for Commit Statuses in order to send updates directly to your PRs without adding comments that spam notifications. Visit our changelog to learn more.

Click here to accept the updated permissions

_{To accept the updated permissions, sufficient privileges are required}

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
lumibot/brokers/ccxt.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

[grzesir]

Thanks for the fixes! We will add this to then next deployment of lumibot