Fix for Alpaca order tracking #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary by Korbit AI
Code Execution Comments
- Remove orders from _unprocessed_orders after processing to avoid memory leaks and tracking inaccuracies.
Files scanned
| File Path | Reviewed |
|---|---|
| lumibot/brokers/alpaca.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
| @@ -447,6 +447,7 @@ def _submit_order(self, order): | |||
| order.set_identifier(response.id) | |||
| order.status = response.status | |||
| order.update_raw(response) | |||
| self._unprocessed_orders.append(order) | |||
There was a problem hiding this comment.
Orders not removed from unprocessed orders list
Tell me more
What is the issue?
Orders are added to _unprocessed_orders but never removed, potentially causing memory leaks and tracking inaccuracies.
Why this matters
Orders will accumulate indefinitely in the _unprocessed_orders list, consuming memory and possibly leading to incorrect order tracking since orders that are completed or cancelled remain in the unprocessed list.
grzesir
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Add unprocessed orders to a tracking list upon order submission in the Alpaca broker integration.
Why are these changes being made?
Previously, orders that were submitted to Alpaca but not processed were not being tracked, potentially leading to discrepancies or missed updates. By appending such orders to the
_unprocessed_orderslist, we ensure more accurate tracking and handling of orders.