Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comments on get_momentum signature #635

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lumibot/entities/bars.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class Bars:
get_last_dividend
Returns the dividend per share value of the last dataframe row

get_momentum(start=None, end=None)
get_momentum(num_periods=1)
Calculates the global price momentum of the dataframe.

aggregate_bars(frequency)
Expand Down
3 changes: 1 addition & 2 deletions lumibot/example_strategies/stock_momentum.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@ def get_assets_momentums(self):
is_live = False

if is_live:
from credentials import ALPACA_CONFIG

from lumibot.credentials import ALPACA_CONFIG
from lumibot.brokers import Alpaca
from lumibot.traders import Trader

Expand Down
Loading