Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re removed deprecated polygon options #519

Merged
merged 4 commits into from
Aug 12, 2024
Merged

re removed deprecated polygon options #519

merged 4 commits into from
Aug 12, 2024

Conversation

Al4ise
Copy link
Collaborator

@Al4ise Al4ise commented Aug 10, 2024

Caused issues after thetadata was merged

Description by Korbit AI

Note

This feature is in early access. You can enable or disable it in the Korbit Console.

Remove deprecated polygon options.

This change removes the deprecated polygon_api_key and polygon_has_paid_subscription options from the run_backtest and backtest functions. These options are no longer necessary as the functionality is now handled automatically, and the api_key parameter should be used instead. This cleanup helps to simplify the code and avoid confusion for users.

@Al4ise Al4ise requested a review from grzesir as a code owner August 10, 2024 11:32
Copy link
Contributor

korbit-ai bot commented Aug 10, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link
Contributor

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@Al4ise
Copy link
Collaborator Author

Al4ise commented Aug 10, 2024

Resolves #518

@grzesir grzesir merged commit 2dbddfe into Lumiwealth:dev Aug 12, 2024
1 check failed
@grzesir
Copy link
Contributor

grzesir commented Aug 12, 2024

merged, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants