Skip to content

Commit

Permalink
[CIS] Build Windows CIS release configuration with "RelWithDebInfo".
Browse files Browse the repository at this point in the history
This should provide debug information for the release configuration.
Also fix declaration of vectored exception handler for Win32 platform in Testbed.
  • Loading branch information
LukasBanana committed Jun 9, 2024
1 parent 783ba29 commit 1e2c215
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:

env:
README: ${{ github.workspace }}/README.txt
CONFIG: ${{ matrix.config == 'Debug' && 'Debug' || 'RelWithDebInfo' }}

steps:
- name: Checkout Repository
Expand All @@ -45,7 +46,7 @@ jobs:
- name: Build
run: |
cmake --build ${{ github.workspace }}/${{ matrix.arch }} --config ${{ matrix.config }}
cmake --build ${{ github.workspace }}/${{ matrix.arch }} --config ${{ env.CONFIG }}
echo "LLGL built with ${{ matrix.generator }} for ${{ matrix.arch }} on $(date)." > ${{ env.README }}
echo "Place at root of LLGL repository to run examples and testbed." >> ${{ env.README }}
Expand All @@ -63,7 +64,7 @@ jobs:
- name: Testbed
working-directory: tests/Testbed
run: |
${{ github.workspace }}/${{ matrix.arch }}/build/${{ matrix.config }}/${{ matrix.config == 'Debug' && 'TestbedD' || 'Testbed' }}.exe d3d12 -v -f -t -g ${{ matrix.config == 'Debug' && '-d=gpu' || '' }}
${{ github.workspace }}/${{ matrix.arch }}/build/${{ env.CONFIG }}/${{ matrix.config == 'Debug' && 'TestbedD' || 'Testbed' }}.exe d3d12 -v -f -t -g ${{ matrix.config == 'Debug' && '-d=gpu' || '' }}
- name: Upload Test Report
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion tests/Testbed/TestbedMain.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ namespace LLGL
LLGL_EXPORT UTF8String DebugStackTrace(unsigned firstStackFrame = 0, unsigned maxNumStackFrames = 64);
};

static LONG TestbedVectoredExceptionHandler(EXCEPTION_POINTERS* e)
static LONG WINAPI TestbedVectoredExceptionHandler(EXCEPTION_POINTERS* e)
{
LLGL::UTF8String stackTrace = DebugStackTrace();
::fprintf(
Expand Down

0 comments on commit 1e2c215

Please sign in to comment.