Added Linux, macOS support, added important comments, improved formatting, fixed hotkey bug #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using pynput instead of pydirectinput, this should make it OS agnostic as long as we have the correct vk keycodes README now explains how to install the requirements before attempting to compile from source
Compiled a Mac binary with the help of @icarlys computer Update the instructions for the README, fixed some grammatical mistakes and made it more clear
|
Update: |
|
@LordHenryVonHenry merge when 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was aimed at making the RobloxMidiConnect program OS agnostic, along the way I fixed some bugs I had encountered and added comments.
I have changed the main method through which keys are sent to use pynput instead of pydirectinput as it works only on Windows.
Created a requirements.txt file in case someone didn't have the necessary dependencies required before attempting to run from source and updated the README.md to reflect that.
Created a compiled linux binary
Fixed the delete keybind to allow starting/pausing the playback of a midi file.
I improved and cleaned some of the existing code making it less repetitive and added some comments to relevant parts of the code explaining its functionality.
Some other minor changes, you can check the commits to see the exact changes.
Notes:
I did not modify the RobloxMidi.exe. I only created the MidiConnectLinux Edit:(and MidiConnectMac) binary using
pyinstaller -Fand thought that it'd be best to leave it to you to update the exe fileI only tested the code on Windows and Linux as I do not have access to a mac device(although I believe it'd work on a mac device as the keycodes have been correctly set)
Edit:
Mac has been tested and is working