Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure Unique Usernames During Profile Updates #322

Closed
wants to merge 6 commits into from

Conversation

othbcq
Copy link
Contributor

@othbcq othbcq commented Dec 20, 2024

This PR implements the functionality to enforce unique usernames when users update their profile information. Previously, while registration ensured unique usernames, profile updates did not. This led to potential duplication and conflicts. The changes address this issue comprehensively.

Changes Included:

  • Username Uniqueness Check:

    • Added backend logic to verify that a new username is not already taken before allowing updates.
    • Integrated this check for both authentication methods (Email/Password and Google Sign-In).
  • Real-Time Feedback:

    • Enhanced the frontend to provide immediate feedback if the desired username is unavailable.
  • Consistent Enforcement:

    • Ensured that the uniqueness constraint is consistently applied across all authentication flows.

Acceptance Criteria Met:

  • Users cannot update their profile with a username that already exists.
  • Users receive clear and immediate feedback when attempting to use an unavailable username.
  • The uniqueness check is enforced consistently for all users.

@othbcq othbcq self-assigned this Dec 20, 2024
@othbcq othbcq linked an issue Dec 20, 2024 that may be closed by this pull request
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.48% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@othbcq
Copy link
Contributor Author

othbcq commented Dec 20, 2024

Due to insufficient code coverage and a lack of time to write additional tests, we have decided to close this PR.

@othbcq othbcq closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Unique Usernames When Updating Profile Information
1 participant