feat: implement landing page with logo and navigation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LandingScreen composable with a clickable background that navigates to the Map screen. - Add a Home button with an icon that navigates to the Menu screen. - Integrate a Box layout for background image and a Column for organizing UI elements. - Apply MaterialTheme and ButtonDefaults for button styling. - Include a Preview composable for easy visualization during development.
- Add test tags to key components in the LandingScreen for testability. - "Background" for the background image. - "Look Up Logo" for the logo image. - "Home Icon" for the home button with the icon. - This change helps with UI testing.
- Add NavHost to MainActivity for handling navigation between LandingScreen and MenuScreen. - Initialize NavController and set LandingScreen as the start destination. - Define composable routes for both LandingScreen and MenuScreen.
- Add the "Landing" route to the Route object. - Update the Screen object to include "Landing Screen".
- Update the version reference for uiTestJunit4Android to ensure compatibility with Compose testing. - Add junitKtx dependency for improved integration with JUnit. - Consolidate existing dependencies to maintain consistency across test implementations.
- Add junitKtx for improved integration with JUnit in testing. - Update the uiTestJunit4Android dependency to align with Compose testing. - Add Espresso Intents testing dependency to support intent validation in UI tests.
- Add landing_screen_bckgrnd.jpg to the drawable resources for use in LandingScreen. - This image will serve as the background for the app's landing page.
- Implement a basic MenuScreen composable that displays a simple text message. - Currently shows "This is the Menu screen" as a placeholder.
-Remove test tags for background image and logo image as they are not used in the tests.
-Add test to verify that the the background image navigates to the map screen. -Add test to verify that the home button navigates to the menu screen.
- Add composable for MapScreen in the navigation graph - Link Route.MAP to MapScreen for proper navigation flow
- Refactor MapScreen and MenuScreen from class-based components to composable functions - Improved alignment with Jetpack Compose architecture and best practices
- Center the logo in the middle of the screen - Make the home button round, change its color and increase its size - Reposition the home button at the bottom of the screen
- Disable XML and HTML reports in testOptions to fix unresolved reference issues. - Adjust test report configuration to prevent coverage errors in CI.
…gradle.skipCompile=true - Prevent Sonar from implicitly triggering project compilation during analysis - Ensure the project is fully compiled before Sonar analysis starts
- Adjust emulator options to disable GPU and improve stability - Ensure emulator cache setup with snapshot generation for faster runs - Include KTFmt check, assemble, lint, and test steps - Add proper handling for AVD creation and caching - Adjust sonar.gradle.skipCompile for efficient Sonar analysis efore Sonar analysis starts
- Re-enabled HTML and JUnit XML test reports for better tracking of test results.
- Re-enable the jacocoTestReport step to generate coverage reports during the CI pipeline execution. - This will allow the CI to generate test coverage reports, which can be uploaded to SonarCloud for analysis.
- Re-enable a previously commented out test for the greeting screen. - Mark the test with @ignore to skip its execution since the test is not necessary for our project.
- Move the LandingScreen tests from unit test directory to androidTest to allow testing in an Android environment.
- Delete multiple versions of the logo image to reduce redundancy and optimize the app's resources. - Kept a single version of the logo.
Add the correct package declaration to Landing.kt to ensure proper organization and avoid potential compilation issues.
… in LandingScreen Replaced the hardcoded "Map" string with the TopLevelDestinations.MAP.route constant to improve maintainability and ensure consistent navigation throughout the app.
rihabbelmekki
requested changes
Oct 13, 2024
There was a problem hiding this comment.
There are some unresolved merge conflicts with the main branch in the dependency files. Please resolve these conflicts, ensuring all necessary dependencies and versions are preserved (e.g., testing, navigation, and calendar libraries). The rest of the implementation looks solid. Once those are addressed, this PR should be good to merge.
Add foundationAndroid version 1.6.8 and configured androidx-foundation-android dependency in libs.versions for managing the Android foundation library consistently across the project
Replace navController.navigate("") with navigateTo from NavigationActions for consistent navigation. Added a prompt "Click for a full map view" to improve user clarity when accessing the full map.
-Include a test for the clickable prompt to ensure proper display and functionality.
Add implementation(libs.androidx.foundation.android) to the Gradle build file for integrating the androidx-foundation-android library.
-Replace older logos with updated versions as part of the design refresh. -Remove deprecated images per review feedback to reduce unused assets.
…onfiguration - Resolve merge conflicts in build.gradle and libs during merge with main - Enable cache configuration to improve build performance - Ensure dependencies and project settings are correctly aligned after the merge
…Screen.MAP as startDestination in MainActivity
raniabbrk
requested review from
rihabbelmekki
and removed request for
rihabbelmekki
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Kenzoud
approved these changes
Oct 14, 2024
rihabbelmekki
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the initial version of the landing page for the project. Key features include: